[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevi
From: |
Liu, Yi L |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice |
Date: |
Mon, 5 Mar 2018 16:11:43 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 02, 2018 at 04:10:48PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > +void pci_setup_sva_ops(PCIDevice *dev, PCISVAOps *ops)
> > +{
> > + if (dev) {
> > + dev->sva_ops = ops;
> > + }
> > + return;
> > +}
> > +
>
> Better:
>
> {
> assert(ops && !dev->sva_ops);
> dev->sva_ops = ops;
> }
Thanks, would apply in next version.
Regards,
Yi Liu
- [Qemu-devel] [PATCH v3 06/12] vfio/pci: provide vfio_pci_sva_ops instance, (continued)
- [Qemu-devel] [PATCH v3 06/12] vfio/pci: provide vfio_pci_sva_ops instance, Liu, Yi L, 2018/03/01
- [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier, Liu, Yi L, 2018/03/01
- Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier, Peter Xu, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier, Liu, Yi L, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier, Peter Xu, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier, Liu, Yi L, 2018/03/08
- Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier, Peter Xu, 2018/03/09
- Re: [Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier, Liu, Yi L, 2018/03/09
[Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice, Liu, Yi L, 2018/03/01
Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice, Liu, Yi L, 2018/03/06
[Qemu-devel] [PATCH v3 09/12] intel_iommu: record assigned devices in a list, Liu, Yi L, 2018/03/01
[Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/01
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/02
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/05
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/06