Re: [Qemu-devel] [qemu-s390x] [PULL-for-s390x 06/14] s390-ccw: parse and set boot menu options

[Thomas Huth]

On 27.02.2018 10:12, Cornelia Huck wrote:
> On Mon, 26 Feb 2018 14:44:45 -0500
> "Collin L. Walling" <address@hidden> wrote:
> 
>> On 02/26/2018 02:29 PM, Collin L. Walling wrote:
>>> On 02/26/2018 01:48 PM, Cornelia Huck wrote:  
>>>> On Mon, 26 Feb 2018 11:42:29 +0100
>>>> Thomas Huth <address@hidden> wrote:
[...]
>>>>> +    switch (ipl->iplb.pbt) {
>>>>> +    case S390_IPL_TYPE_CCW:
>>>>> +        break;
>>>>> +    default:
>>>>> +        error_report("boot menu is not supported for this device 
>>>>> type.");  
>>>> If I specify both a bootindex for a device and a -kernel parameter, I
>>>> get this error message. Looks a tad odd, but not sure how to avoid it.  
>>>
>>> Hmm... perhaps an additional check if no IPLB, then skip trying to set
>>> any boot menu data?
[...]
> How shall we proceed? I'd be willing to pull this now and then apply
> fixups on top, or we can have a respin. Thomas?

Since this is about a change in hw/s390x/ and not about
pc-bios/s390-ccw/ (i.e. no need to rebuild the firmware binaries for
this), I think I'd rather prefer a fix-up patch on top instead of a re-spin.

 Thomas