[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] HACK: HobLib: workaround infinite loop
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] HACK: HobLib: workaround infinite loop |
Date: |
Fri, 23 Feb 2018 20:14:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/23/18 14:23, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Without this hack, GetNextHob() loops infinitely with the next patch.
> I don't understand the reason.
>
> The loop is triggered by the GetFirstGuidHob (&gTpmErrorHobGuid) call.
>
> CC: Laszlo Ersek <address@hidden>
> CC: Stefan Berger <address@hidden>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> MdePkg/Library/PeiHobLib/HobLib.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MdePkg/Library/PeiHobLib/HobLib.c
> b/MdePkg/Library/PeiHobLib/HobLib.c
> index 5c0eeb992f..ed3c5fbd6d 100644
> --- a/MdePkg/Library/PeiHobLib/HobLib.c
> +++ b/MdePkg/Library/PeiHobLib/HobLib.c
> @@ -89,6 +89,10 @@ GetNextHob (
> if (Hob.Header->HobType == Type) {
> return Hob.Raw;
> }
> + if (GET_HOB_LENGTH (HobStart) == 0) {
> + DEBUG ((DEBUG_INFO, "FIXME: GetNextHob length == 0"));
> + return NULL;
> + }
> Hob.Raw = GET_NEXT_HOB (Hob);
> }
> return NULL;
>
Strange. The HobLength field is supposed to include the size of the HOB header,
so it should never be zero.
Furthermore, the PEI core initializes the HOB list; it should be terminated
with an End-of-HOB-List HOB:
PeiCore() [MdeModulePkg/Core/Pei/PeiMain/PeiMain.c]
InitializeMemoryServices()
[MdeModulePkg/Core/Pei/Memory/MemoryServices.c]
PeiCoreBuildHobHandoffInfoTable() [MdeModulePkg/Core/Pei/Hob/Hob.c]
I tried to reproduce this issue by:
- applying patches 1, 2, and 4
- in function PeimEntryMA(), file "SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c", moving
the GetFirstGuidHob (&gTpmErrorHobGuid) call to the top of the function.
It didn't hang for me.
Laszlo
- [Qemu-devel] [PATCH 0/7] RFC: ovmf: preliminary TPM2 support, marcandre . lureau, 2018/02/23
- [Qemu-devel] [PATCH 2/7] ovmf: link with Tcg2ConfigPei module, marcandre . lureau, 2018/02/23
- [Qemu-devel] [PATCH 4/7] ovmf: link with Tcg2Pei module, marcandre . lureau, 2018/02/23
- [Qemu-devel] [PATCH 3/7] HACK: HobLib: workaround infinite loop, marcandre . lureau, 2018/02/23
- [Qemu-devel] [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib dependency, marcandre . lureau, 2018/02/23
- [Qemu-devel] [PATCH 5/7] ovmf: link with Tcg2Dxe module, marcandre . lureau, 2018/02/23
- [Qemu-devel] [PATCH 6/7] ovmf: link with Tcg2ConfigDxe module, marcandre . lureau, 2018/02/23
- [Qemu-devel] [PATCH 7/7] ovmf: add DxeTpm2MeasureBootLib, marcandre . lureau, 2018/02/23