[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes |
Date: |
Fri, 23 Feb 2018 13:25:25 +0100 |
Hi
On Fri, Feb 23, 2018 at 12:37 PM, Paolo Bonzini <address@hidden> wrote:
> On 15/02/2018 22:25, Marc-André Lureau wrote:
>> Hi,
>>
>> The following patches fix a regression introduced in commit
>> 218bb57dd79d that prevent ASAN from being detected & used. There is
>> also a works around for a GCC ASAN optimization bug. A few test leaks
>> are fixed, and a few patches reenable vhost-user memfd test fixing the
>> recent race bug that was identified in the previous version.
>>
>> Marc-André Lureau (6):
>> build-sys: fix -fsanitize=address check
>> lockable: workaround GCC link issue with ASAN
>> vhost-user-test: add back memfd check
>> vhost-user-test: do not hang if chardev creation failed
>> ahci-test: fix opts leak of skip tests
>> sdhci-test: fix leaks
>>
>> include/qemu/lockable.h | 2 +-
>> tests/ahci-test.c | 1 +
>> tests/sdhci-test.c | 2 ++
>> tests/vhost-user-test.c | 94
>> +++++++++++++++++++++++++++++++++++--------------
>> configure | 22 ++++++------
>> 5 files changed, 83 insertions(+), 38 deletions(-)
>>
>
> Queued 1-2-5-6, not really confident enough in what's going on with
> vhost-user-test. :)
It hangs when chardev creation fails. Which is apparent when running
with --debug-log. That's also why I added "vhost-user-test: do not
hang if chardev creation failed". The problem comes from reusing
socket location without waiting for the idle cleanup. Using different
socket path solves it (vhost-user-test: add back memfd check)
Maxime, could you help review those patches?
thanks
--
Marc-André Lureau
- [Qemu-devel] [PATCH 2/6] lockable: workaround GCC link issue with ASAN, (continued)
- [Qemu-devel] [PATCH 2/6] lockable: workaround GCC link issue with ASAN, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 6/6] sdhci-test: fix leaks, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 5/6] ahci-test: fix opts leak of skip tests, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 4/6] vhost-user-test: do not hang if chardev creation failed, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 3/6] vhost-user-test: add back memfd check, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 1/6] build-sys: fix -fsanitize=address check, Marc-André Lureau, 2018/02/15
- Re: [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes, Paolo Bonzini, 2018/02/23
- Re: [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes,
Marc-André Lureau <=