Re: [Qemu-devel] [PATCH v2 24/36] rbd: Use qemu_rbd_connect() in qemu_rbd_do_create()

[Max Reitz]

On 2018-02-21 14:53, Kevin Wolf wrote:
> This is almost exactly the same code. The differences are that
> qemu_rbd_connect() supports BlockdevOptionsRbd.server and that the cache
> mode is set explicitly.
> 
> Supporting 'server' is a welcome new feature for image creation.
> Caching is disabled by default, so leave it that way.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/rbd.c | 54 ++++++++++--------------------------------------------
>  1 file changed, 10 insertions(+), 44 deletions(-)
> 
> diff --git a/block/rbd.c b/block/rbd.c
> index a34bf0be46..af8e186106 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c

[...]

> @@ -370,54 +369,21 @@ static int qemu_rbd_do_create(BlockdevCreateOptions 
> *options,
>          obj_order = ctz32(objsize);
>      }
>  
> -    ret = rados_create(&cluster, opts->location->user);
> +    ret = qemu_rbd_connect(&cluster, &io_ctx, opts->location, false, 
> keypairs,
> +                           NULL, errp);

s/NULL/password_secret/?

Max

signature.asc
Description: OpenPGP digital signature