Re: [Qemu-devel] [PATCH v2 14/36] block: x-blockdev-create QMP command

[Eric Blake]

On 02/21/2018 07:53 AM, Kevin Wolf wrote:
> This adds a synchronous x-blockdev-create QMP command that can create
> qcow2 images on a given node name.
>
> We don't want to block while creating an image, so this is not the final
> interface in all aspects, but BlockdevCreateOptionsQcow2 and
> .bdrv_co_create() are what they actually might look like in the end. In
> any case, this should be good enough to test whether we interpret
> BlockdevCreateOptions as we should.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   qapi/block-core.json      | 12 ++++++++
>   include/block/block_int.h |  2 ++
>   block/create.c            | 76 +++++++++++++++++++++++++++++++++++++++++++++++
>   block/qcow2.c             |  3 +-
>   block/Makefile.objs       |  2 +-
>   5 files changed, 93 insertions(+), 2 deletions(-)
>   create mode 100644 block/create.c

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org