[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model |
Date: |
Thu, 22 Feb 2018 15:55:00 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/22/2018 01:11 PM, Peter Maydell wrote:
ERROR: line over 90 characters
#54: FILE: hw/arm/mps2-tz.c:21:
+ *
https://developer.arm.com/products/system-design/development-boards/fpga-prototyping-boards/mps2
Does anybody better with perl and more familiar with checkpatch's
internals feel like tweaking it to suppress the over-long-line
complaint for URLs ?
This one-liner appears to do the trick; I'll submit it formally in
another thread:
diff --git i/scripts/checkpatch.pl w/scripts/checkpatch.pl
index 1b4b812e28f..0d3f753c665 100755
--- i/scripts/checkpatch.pl
+++ w/scripts/checkpatch.pl
@@ -1447,9 +1447,10 @@ sub process {
# check we are in a valid source file if not then ignore this hunk
next if ($realfile !~ /$SrcFile/);
-#90 column limit
+#90 column limit; exempt URLs, if no other words on line
if ($line =~ /^\+/ &&
!($line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
+ !($rawline =~ /^[^[:alnum:]]*https?:\S*$/) &&
$length > 80)
{
if ($length > 90) {
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH 02/19] hw/arm/boot: Honour CPU's address space for image loads, (continued)
- [Qemu-devel] [PATCH 02/19] hw/arm/boot: Honour CPU's address space for image loads, Peter Maydell, 2018/02/20
- [Qemu-devel] [PATCH 04/19] target/arm: Define an IDAU interface, Peter Maydell, 2018/02/20
- [Qemu-devel] [PATCH 07/19] armv7m: Forward init-svtor property to CPU object, Peter Maydell, 2018/02/20
- [Qemu-devel] [PATCH 12/19] hw/core/split-irq: Device that splits IRQ lines, Peter Maydell, 2018/02/20
- [Qemu-devel] [PATCH 19/19] mps2-an505: New board model: MPS2 with AN505 Cortex-M33 FPGA image, Peter Maydell, 2018/02/20
- [Qemu-devel] [PATCH 18/19] hw/arm/iotkit: Model Arm IOT Kit, Peter Maydell, 2018/02/20
- Re: [Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model, no-reply, 2018/02/22
- Re: [Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model, no-reply, 2018/02/24