[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState |
Date: |
Thu, 22 Feb 2018 15:46:17 +0000 |
On 22 February 2018 at 15:37, Gerd Hoffmann <address@hidden> wrote:
> On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote:
>> vfio display support wants disable hotplug for certain devices, because
>> qemu doesn't support hotplugging display devices and qemu consoles.
>>
>> Add a hotpluggable bool to DeviceState, initialize it from
>> DeviceClass->hotpluggable, update device_get_hotpluggable accordingly.
>>
>> Devices can flip the new variable from true to false if needed.
>
> Alex wants an ack for this one. Who maintains it these days?
>
> MAINTAINERS doesn't list qdev. For QOM which is closest probably
> Andreas Färber is listed. Havn't seen him on the list for a while
> though.
>
> Ok, lets try some usual suspects...
> Markus? Eric? Paolo? Peter? Any comments on this one?
What type of device is only sometimes hotpluggable ?
The commit message says "display devices" and "consoles",
but I would expect those to both be types of device which
have a class which is never hotpluggable, so you can mark
them non-hotpluggable with the existing class flag rather
than needing a per-instance flag.
thanks
-- PMM
- [Qemu-devel] [PATCH v4 0/7] vfio: add display support, Gerd Hoffmann, 2018/02/19
- [Qemu-devel] [PATCH v4 5/7] vfio/common: cleanup in vfio_region_finalize, Gerd Hoffmann, 2018/02/19
- [Qemu-devel] [PATCH v4 2/7] standard-headers: add drm/drm_fourcc.h, Gerd Hoffmann, 2018/02/19
- [Qemu-devel] [PATCH v4 3/7] ui/pixman: add qemu_drm_format_to_pixman(), Gerd Hoffmann, 2018/02/19
- [Qemu-devel] [PATCH v4 6/7] vfio/display: core & wireup, Gerd Hoffmann, 2018/02/19
- [Qemu-devel] [PATCH v4 7/7] vfio/display: adding region support, Gerd Hoffmann, 2018/02/19
- [Qemu-devel] [PATCH v4 1/7] linux-headers: update to 4.16-rc1, Gerd Hoffmann, 2018/02/19
- [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Gerd Hoffmann, 2018/02/19
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Gerd Hoffmann, 2018/02/22
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Alex Williamson, 2018/02/22
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Peter Maydell, 2018/02/22
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Zhenyu Wang, 2018/02/22
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Gerd Hoffmann, 2018/02/23
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Alex Williamson, 2018/02/23
- Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState, Gerd Hoffmann, 2018/02/26
Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support, Alex Williamson, 2018/02/19