Re: [Qemu-devel] [PATCH v3 1/5] aio: rename aio_context_in_iothread() to in_aio_context_home_thread()

[Eric Blake]

On 02/16/2018 10:50 AM, Stefan Hajnoczi wrote:
> The name aio_context_in_iothread() is misleading because it also return

s/return/returns/

> true when called on the main AioContext from the main loop thread, which
> is not an IOThread.
>
> This patch renames it to in_aio_context_home_thread() and expands the
> doc comment to make the semantics clearer.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>   include/block/aio.h   | 7 +++++--
>   include/block/block.h | 2 +-
>   2 files changed, 6 insertions(+), 3 deletions(-)

>   /**
> + * in_aio_context_home_thread:
>    * @ctx: the aio context
>    *
> - * Return whether we are running in the I/O thread that manages @ctx.
> + * Return whether we are running in the thread that normally runs @ctx.  Note
> + * that acquiring/releasing ctx does not affect the outcome, each AioContext
> + * still only has a one home thread that is responsible for running it.

s/a one/one/

Typo fixes are trivial, so

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org