Re: [Qemu-devel] [PATCH 08/27] util: Add qemu_opts_to_qdict_filtered()

[Eric Blake]

On 02/08/2018 01:23 PM, Kevin Wolf wrote:
> This allows, given a QemuOpts for a QemuOptsList that was merged from
> multiple QemuOptsList, to only consider those options that exist in one
> specific list. Block drivers need this to separate format-layer create
> options from protocol-level options.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   include/qemu/option.h |  2 ++
>   util/qemu-option.c    | 37 ++++++++++++++++++++++++++++++++-----
>   2 files changed, 34 insertions(+), 5 deletions(-)

Is there any unit test coverage we should be adding, beyond the default 
we get when the list parameter is NULL?

But what you have looks sane;
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org