[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] spapr: drop DIV_ROUND_UP() from xics_max_se
|
From: |
Greg Kurz |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/5] spapr: drop DIV_ROUND_UP() from xics_max_server_number() |
|
Date: |
Thu, 15 Feb 2018 17:08:57 +0100 |
On Thu, 15 Feb 2018 15:08:18 +1100
David Gibson <address@hidden> wrote:
> On Wed, Feb 14, 2018 at 08:41:03PM +0100, Greg Kurz wrote:
<snip>
> >
> > It breaks migration of pre-2.7 machine types with unusual CPU topologies,
> > but I guess this is an acceptable trade-off.
>
> No, not really. Weird topologies are still allowed on old machine
> types for backwards compatibility, and we shouldn't break that. I
> like the idea of consolidating this calculation, but we can't do it by
> just breaking the older machines (at least not until they're formally
> deprecated).
>
Heh, I had put this patch at the end because I was expecting you might
nack it :)
Per curiosity, when/how do we decide that an older machine type may be formally
deprecated ?
- [Qemu-devel] [PATCH 0/5] spapr: fix VCPU ids miscalculation, Greg Kurz, 2018/02/14
- [Qemu-devel] [PATCH 1/5] spapr: use spapr->vsmt to compute VCPU ids, Greg Kurz, 2018/02/14
- [Qemu-devel] [PATCH 2/5] spapr: move VCPU calculation to core machine code, Greg Kurz, 2018/02/14
- [Qemu-devel] [PATCH 3/5] spapr: rename spapr_vcpu_id() to spapr_get_vcpu_id(), Greg Kurz, 2018/02/14
- [Qemu-devel] [PATCH 4/5] spapr: consolidate the VCPU id numbering logic in a single place, Greg Kurz, 2018/02/14
- [Qemu-devel] [PATCH 5/5] spapr: drop DIV_ROUND_UP() from xics_max_server_number(), Greg Kurz, 2018/02/14