[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation |
Date: |
Wed, 14 Feb 2018 14:52:18 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Feb 14, 2018 at 11:14:48 -0800, Richard Henderson wrote:
> On 02/13/2018 04:10 PM, Emilio G. Cota wrote:
> > On Tue, Feb 13, 2018 at 14:10:20 -0800, Richard Henderson wrote:
> >> On 02/13/2018 01:55 PM, Emilio G. Cota wrote:
> >>> Are we planning to use BS_STOP in the future? I see it has no setters,
> >>> although we check for it in gen_intermediate_code:
> >>
> >> No, but the whole port should be converted to exec/translator.h, which
> >> defines
> >> DisasJumpType. Not something I'm going to require on initial submission
> >> until
> >> we've gotten most of the other targets cleaned up.
> >
> > I see. I've just done the conversion for v5:
> > https://github.com/cota/qemu/commits/riscv-v5-trloop
> >
> > Can you please take a look?
>
> Looks ok. Watch your formatting, e.g { } on the same line.
Thanks, checkpatch didn't complain about that one though.
Should I send those patches to the list, or let Michael squash their changes?
E.
- [Qemu-devel] [PATCH v5 04/23] RISC-V Disassembler, (continued)
- [Qemu-devel] [PATCH v5 04/23] RISC-V Disassembler, Michael Clark, 2018/02/07
- [Qemu-devel] [PATCH v5 10/23] RISC-V Physical Memory Protection, Michael Clark, 2018/02/07
- [Qemu-devel] [PATCH v5 11/23] RISC-V Linux User Emulation, Michael Clark, 2018/02/07
- [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Michael Clark, 2018/02/07
- Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Emilio G. Cota, 2018/02/13
- Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Richard Henderson, 2018/02/13
- Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Emilio G. Cota, 2018/02/13
- Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Richard Henderson, 2018/02/14
- Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation,
Emilio G. Cota <=
- Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Richard Henderson, 2018/02/14
- Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Emilio G. Cota, 2018/02/14
Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation, Emilio G. Cota, 2018/02/13
[Qemu-devel] [PATCH v5 13/23] RISC-V HART Array, Michael Clark, 2018/02/07
[Qemu-devel] [PATCH v5 12/23] RISC-V HTIF Console, Michael Clark, 2018/02/07