|
From: | Alberto Garcia |
Subject: | Re: [Qemu-devel] [PATCH v4 37/39] iotests: Test valid values of l2-cache-entry-size |
Date: | Tue, 13 Feb 2018 13:36:16 +0100 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 13 Feb 2018 01:32:17 PM CET, Kevin Wolf wrote: >> +# Invalid cache entry sizes >> +$QEMU_IO -c "open -o l2-cache-entry-size=256 $TEST_IMG" \ >> + 2>&1 | _filter_testdir | _filter_imgfmt >> +$QEMU_IO -c "open -o l2-cache-entry-size=300 $TEST_IMG" \ >> + 2>&1 | _filter_testdir | _filter_imgfmt > > If you wanted to test non-power-of-two values here, it would be better > to use a value that isn't < 512 at the same time. Good idea, if there's no new version of the series whoever applies this can feel free to change this value to 3000 or something like that. Berto
[Prev in Thread] | Current Thread | [Next in Thread] |