[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 25/27] block: Fail bdrv_truncate() with negative
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH 25/27] block: Fail bdrv_truncate() with negative size |
|
Date: |
Mon, 12 Feb 2018 18:42:08 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-02-08 20:23, Kevin Wolf wrote:
> Most callers have their own checks, but something like this should also
> be checked centrally. As it happens, x-blockdev-create can pass negative
> image sizes to format drivers (because there is no QAPI type that would
> reject negative numbers) and triggers the check added by this patch.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object, (continued)
- [Qemu-devel] [PATCH 21/27] ssh: QAPIfy host-key-check option, Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 22/27] ssh: Pass BlockdevOptionsSsh to connect_to_ssh(), Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 24/27] file-posix: Fix no-op bdrv_truncate() with falloc preallocation, Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 23/27] ssh: Support .bdrv_co_create, Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 25/27] block: Fail bdrv_truncate() with negative size, Kevin Wolf, 2018/02/08
- Re: [Qemu-devel] [PATCH 25/27] block: Fail bdrv_truncate() with negative size,
Max Reitz <=
- [Qemu-devel] [PATCH 26/27] qemu-iotests: Test qcow2 over file image creation with QMP, Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 27/27] qemu-iotests: Test ssh image creation over QMP, Kevin Wolf, 2018/02/08