[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-blo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block |
Date: |
Mon, 12 Feb 2018 15:50:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 12/02/2018 15:48, Kevin Wolf wrote:
> Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben:
>> Okay, we are in agreement about this and you expressed very well why I
>> (at the gut feeling level) didn't like the old op blockers. But you
>> bypassed the real question, which is: should I send a pull request for
>> these two patches or not? :)
>
> I didn't spell it out that explicitly, but this is essentially a NACK.
> I'd very much prefer if you could replace it with the proper solution.
> Of course, we can always make exceptions when there is a good reason,
> but with 2.12 still two months away, I doubt we have one.
Ok, I don't mind explicitness. I'll keep these two patches in the queue
for now.
Paolo
- [Qemu-devel] [PATCH 0/2] scsi: add block job opblockers for scsi-block, Paolo Bonzini, 2018/02/07
- [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Paolo Bonzini, 2018/02/07
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Fam Zheng, 2018/02/07
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Paolo Bonzini, 2018/02/08
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Kevin Wolf, 2018/02/12
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Paolo Bonzini, 2018/02/12
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Kevin Wolf, 2018/02/12
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Paolo Bonzini, 2018/02/12
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block, Kevin Wolf, 2018/02/12
- Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block,
Paolo Bonzini <=
[Qemu-devel] [PATCH 1/2] scsi: add unrealize method for SCSI devices, Paolo Bonzini, 2018/02/07