Re: [Qemu-devel] [PATCH v2] S390: Expose s390-specific CPU info

[Eric Blake]

On 02/08/2018 10:43 AM, Viktor Mihajlovski wrote:
> Presently s390x is the only architecture not exposing specific
> CPU information via QMP query-cpus. Upstream discussion has shown
> that it could make sense to report the architecture specific CPU
> state, e.g. to detect that a CPU has been stopped.
>
> With this change the output of query-cpus will look like this on
> s390:
>
>     [
>       {"arch": "s390", "current": true,
>        "props": {"core-id": 0}, "cpu-state": "operating", "CPU": 0,
>        "qom_path": "/machine/unattached/device[0]",
>        "halted": false, "thread_id": 63115},
>       {"arch": "s390", "current": false,
>        "props": {"core-id": 1}, "cpu-state": "stopped", "CPU": 1,


So the addition here is the "cpu-state" member.

QAPI changes are fine; I didn't look at the corresponding code, though, 
so you may add the weaker:

Acked-by: Eric Blake <address@hidden>


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org