|
From: | Denis V. Lunev |
Subject: | Re: [Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller |
Date: | Wed, 7 Feb 2018 14:25:05 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/07/2018 02:11 PM, Paolo Bonzini wrote: > On 06/02/2018 21:30, Roman Kagan wrote: >> + blk_io_plug(d->conf.blk); >> + if (scsi_req_enqueue(sreq)) { >> + scsi_req_continue(sreq); >> + } >> + blk_io_unplug(d->conf.blk); > Is plug/unplug really useful? > > Paolo good point. here - no. plug/unplug should be moved to upper layer, where we process all requests. Plug/Unplug should cover all currently available bits. Den
[Prev in Thread] | Current Thread | [Next in Thread] |