[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] migration: Don't leak IO channels
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] migration: Don't leak IO channels |
Date: |
Tue, 6 Feb 2018 11:17:44 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Ross Lagerwall (address@hidden) wrote:
> Since qemu_fopen_channel_{in,out}put take references on the underlying
> IO channels, make sure to release our references to them.
>
> Signed-off-by: Ross Lagerwall <address@hidden>
Queued for migration.
Dave
> ---
> New in v2.
>
> migration/savevm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 4a88228..87557dd 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2259,6 +2259,7 @@ void qmp_xen_save_devices_state(const char *filename,
> Error **errp)
> }
> qio_channel_set_name(QIO_CHANNEL(ioc), "migration-xen-save-state");
> f = qemu_fopen_channel_output(QIO_CHANNEL(ioc));
> + object_unref(OBJECT(ioc));
> ret = qemu_save_device_state(f);
> qemu_fclose(f);
> if (ret < 0) {
> @@ -2292,6 +2293,7 @@ void qmp_xen_load_devices_state(const char *filename,
> Error **errp)
> }
> qio_channel_set_name(QIO_CHANNEL(ioc), "migration-xen-load-state");
> f = qemu_fopen_channel_input(QIO_CHANNEL(ioc));
> + object_unref(OBJECT(ioc));
>
> ret = qemu_loadvm_state(f);
> qemu_fclose(f);
> --
> 2.9.5
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 1/4] migration: Don't leak IO channels,
Dr. David Alan Gilbert <=