[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 11/26] block: Add bdrv_dirname()
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v8 11/26] block: Add bdrv_dirname() |
Date: |
Mon, 5 Feb 2018 16:18:20 +0100 |
This function may be implemented by block drivers to derive a directory
name from a BDS. Concatenating this g_free()-able string with a relative
filename must result in a valid (not necessarily existing) filename, so
this is a function that should generally be not implemented by format
drivers, because this is protocol-specific.
If a BDS's driver does not implement this function, bdrv_dirname() will
fall through to the BDS's file if it exists. If it does not, the
exact_filename field will be used to generate a directory name.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
include/block/block.h | 1 +
include/block/block_int.h | 7 +++++++
block.c | 26 ++++++++++++++++++++++++++
3 files changed, 34 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index fafb8a6a7a..1983055916 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -485,6 +485,7 @@ char *bdrv_get_full_backing_filename(BlockDriverState *bs,
Error **errp);
char *bdrv_get_full_backing_filename_from_filename(const char *backed,
const char *backing,
Error **errp);
+char *bdrv_dirname(BlockDriverState *bs, Error **errp);
int path_has_protocol(const char *path);
int path_is_absolute(const char *path);
diff --git a/include/block/block_int.h b/include/block/block_int.h
index b5c124fcbd..8b0413e3df 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -135,6 +135,13 @@ struct BlockDriver {
void (*bdrv_refresh_filename)(BlockDriverState *bs, QDict *options);
+ /*
+ * Returns an allocated string which is the directory name of this BDS: It
+ * will be used to make relative filenames absolute by prepending this
+ * function's return value to them.
+ */
+ char *(*bdrv_dirname)(BlockDriverState *bs, Error **errp);
+
/* aio */
BlockAIOCB *(*bdrv_aio_readv)(BlockDriverState *bs,
int64_t sector_num, QEMUIOVector *qiov, int nb_sectors,
diff --git a/block.c b/block.c
index 06ee694ac5..8957a3d4dc 100644
--- a/block.c
+++ b/block.c
@@ -5153,6 +5153,32 @@ void bdrv_refresh_filename(BlockDriverState *bs)
}
}
+char *bdrv_dirname(BlockDriverState *bs, Error **errp)
+{
+ BlockDriver *drv = bs->drv;
+
+ if (!drv) {
+ error_setg(errp, "Node '%s' is ejected", bs->node_name);
+ return NULL;
+ }
+
+ if (drv->bdrv_dirname) {
+ return drv->bdrv_dirname(bs, errp);
+ }
+
+ if (bs->file) {
+ return bdrv_dirname(bs->file->bs, errp);
+ }
+
+ if (bs->exact_filename[0] != '\0') {
+ return path_combine(bs->exact_filename, "");
+ }
+
+ error_setg(errp, "Cannot generate a base directory for %s nodes",
+ drv->format_name);
+ return NULL;
+}
+
/*
* Hot add/remove a BDS's child. So the user can take a child offline when
* it is broken and take a new child online
--
2.14.3
- Re: [Qemu-devel] [PATCH v8 04/26] iotests: Drop explicit base blockdev in 191, (continued)
- [Qemu-devel] [PATCH v8 05/26] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 06/26] block: Make path_combine() return the path, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 07/26] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 08/26] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 09/26] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 10/26] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 11/26] block: Add bdrv_dirname(),
Max Reitz <=
- [Qemu-devel] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 13/26] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 16/26] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 19/26] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 17/26] iotests: Add quorum case to test 110, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/02/05