qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes
Date: Thu, 1 Feb 2018 10:27:37 +0800

On Wed, Jan 31, 2018 at 11:48 PM, Thomas Huth <address@hidden> wrote:
> On 31.01.2018 15:48, Markus Armbruster wrote:
>> Clean up includes so that osdep.h is included first and headers
>> which it implies are not included manually.
>>
>> This commit was created with scripts/clean-includes, with the change
>> to target/s390x/gen-features.c manually reverted, and blank lines
>> around deletions collapsed.
>
> Reviewed-by: Thomas Huth <address@hidden>
>
> I wonder whether it would make sense to add a check based on
> scripts/clean-includes to patchew already, so that these includes do not
> sneak in so easily again...?

(Having not looked at the series), are we clean with this series
applied? If so it makes a good point to do so.

Fam

>
>  Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]