[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm' |
Date: |
Wed, 31 Jan 2018 18:43:47 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Brijesh Singh <address@hidden> writes:
> update 'info kvm' to display the memory encryption support.
>
> (qemu) info kvm
> kvm support: enabled
> memory encryption: disabled
>
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Cc: Eric Blake <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Brijesh Singh <address@hidden>
> ---
> hmp.c | 2 ++
> qapi-schema.json | 5 ++++-
> qmp.c | 1 +
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hmp.c b/hmp.c
> index 056bf70cf1e2..6ceb6b30af75 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -88,6 +88,8 @@ void hmp_info_kvm(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "kvm support: ");
> if (info->present) {
> monitor_printf(mon, "%s\n", info->enabled ? "enabled" : "disabled");
> + monitor_printf(mon, "memory encryption: %s\n",
> + info->mem_encryption ? "enabled" : "disabled");
> } else {
> monitor_printf(mon, "not compiled\n");
> }
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 5c06745c7927..2046c96669bf 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -314,9 +314,12 @@
> #
> # @present: true if KVM acceleration is built into this executable
> #
> +# @mem-encryption: true if Memory Encryption is active (since 2.12)
> +#
> # Since: 0.14.0
> ##
> -{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool'} }
> +{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool',
> + 'mem-encryption' : 'bool'} }
This extends QMP's query-kvm. Your commit message claims the patch
affects only HMP. Needs fixing. The cleanest way is to split the patch
into its QMP part (hunks #2 and #3) and its HMP part (hunk #1).
>
> ##
> # @query-kvm:
> diff --git a/qmp.c b/qmp.c
> index 52cfd2d81c0f..3a527bc8c39c 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -69,6 +69,7 @@ KvmInfo *qmp_query_kvm(Error **errp)
>
> info->enabled = kvm_enabled();
> info->present = kvm_available();
> + info->mem_encryption = kvm_memcrypt_enabled();
>
> return info;
> }
- Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support, (continued)
- Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support, Dr. David Alan Gilbert, 2018/01/30
- Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support, Brijesh Singh, 2018/01/30
- Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support, Brijesh Singh, 2018/01/30
- Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support, Dr. David Alan Gilbert, 2018/01/31
- Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support, Eduardo Habkost, 2018/01/31
- Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support, Brijesh Singh, 2018/01/31
[Qemu-devel] [PATCH v6 09/23] accel: add Secure Encrypted Virtulization (SEV) object, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 07/23] kvm: update kvm.h to include memory encryption ioctls, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 11/23] sev: register the guest memory range which may contain encrypted data, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm', Brijesh Singh, 2018/01/29
- Re: [Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm',
Markus Armbruster <=
[Qemu-devel] [PATCH v6 12/23] kvm: introduce memory encryption APIs, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 15/23] sev: add command to encrypt guest memory region, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 14/23] sev: add command to create launch memory encryption context, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 10/23] sev: add command to initialize the memory encryption context, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 18/23] sev: emit the SEV_MEASUREMENT event, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 17/23] qapi: add SEV_MEASUREMENT event, Brijesh Singh, 2018/01/29
[Qemu-devel] [PATCH v6 16/23] target/i386: encrypt bios rom, Brijesh Singh, 2018/01/29