[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] scripts/make-release: Don't archive .git fil
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3] scripts/make-release: Don't archive .git files |
Date: |
Tue, 30 Jan 2018 21:31:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 30.01.2018 20:33, Cole Robinson wrote:
> As was last done in 379e21c25, we don't want .git files for
> submodules here, which we aren't presently doing for capstone and
> keycodemapdb.
>
> Rather than delete the offending files before archiving, ask tar
> to --exclude=.git
>
> Signed-off-by: Cole Robinson <address@hidden>
> ---
> v2:
> Use armbru's --exclude suggestion, requires tweaking
> existing tar options a bit.
>
> v3:
> thuth's suggestion to use --exclude for both tar commands
>
> scripts/make-release | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/make-release b/scripts/make-release
> index 3917df7142..04fa9defdc 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -19,11 +19,10 @@ pushd ${destination}
> git checkout "v${version}"
> git submodule update --init
> (cd roms/seabios && git describe --tags --long --dirty > .version)
> -rm -rf .git roms/*/.git dtc/.git pixman/.git
Thanks, this also fixes the dead pixman/.git path :-)
Reviewed-by: Thomas Huth <address@hidden>