[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/3] Tracing patches
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PULL 0/3] Tracing patches |
Date: |
Tue, 30 Jan 2018 11:58:57 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Jan 29, 2018 at 08:14:46AM -0800, address@hidden wrote:
> === OUTPUT BEGIN ===
> Checking PATCH 1/3: tracetool: prefix parse errors with line numbers...
> Checking PATCH 2/3: tracetool: clarify that "formats" means "format
> strings"...
> ERROR: line over 90 characters
> #39: FILE: scripts/tracetool/__init__.py:240:
> + raise ValueError("Only events with 'tcg' property can have two
> format strings")
>
> WARNING: line over 80 characters
> #42: FILE: scripts/tracetool/__init__.py:242:
> + raise ValueError("Events with 'tcg' property must have two
> format strings")
>
> total: 1 errors, 1 warnings, 27 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)...
> WARNING: line over 80 characters
> #26: FILE: scripts/tracetool/__init__.py:79:
> + raise ValueError("Empty argument (did you forget to use
> 'void'?)")
>
> total: 0 errors, 1 warnings, 8 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> === OUTPUT END ===
For the record, I didn't wrap these error messages so that grep(1)
works.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PULL 0/3] Tracing patches, Stefan Hajnoczi, 2018/01/29
- [Qemu-devel] [PULL 1/3] tracetool: prefix parse errors with line numbers, Stefan Hajnoczi, 2018/01/29
- [Qemu-devel] [PULL 2/3] tracetool: clarify that "formats" means "format strings", Stefan Hajnoczi, 2018/01/29
- [Qemu-devel] [PULL 3/3] tracetool: report error on foo() instead of foo(void), Stefan Hajnoczi, 2018/01/29
- Re: [Qemu-devel] [PULL 0/3] Tracing patches, no-reply, 2018/01/29
- Re: [Qemu-devel] [PULL 0/3] Tracing patches,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PULL 0/3] Tracing patches, Peter Maydell, 2018/01/30