[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema |
Date: |
Mon, 29 Jan 2018 19:06:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-01-29 19:06, Kevin Wolf wrote:
> Am 29.01.2018 um 17:57 hat Max Reitz geschrieben:
>> On 2018-01-11 20:52, Kevin Wolf wrote:
>>> Signed-off-by: Kevin Wolf <address@hidden>
>>> ---
>>> qapi/block-core.json | 33 ++++++++++++++++++++++++++++++++-
>>> 1 file changed, 32 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>>> index 1749376c61..9341f6708d 100644
>>> --- a/qapi/block-core.json
>>> +++ b/qapi/block-core.json
>>> @@ -3320,6 +3320,37 @@
>>> { 'command': 'blockdev-del', 'data': { 'node-name': 'str' } }
>>>
>>> ##
>>> +# @BlockdevQcow2CompatLevel:
>>> +# @0_10: The original QCOW2 format as introduced in qemu 0.10 (version
>>> 2)
>>> +# @1_1: The extended QCOW2 format as introduced in qemu 1.1 (version 3)
>>> +#
>>> +# Since: 2.10
>>> +##
>>> +{ 'enum': 'BlockdevQcow2CompatLevel',
>>> + 'data': [ '0_10', '1_1' ] }
>>
>> Just my two cents: I'd prefer 2 and 3 because I've never quite liked
>> that people are supposed to remember some pretty random qemu version
>> numbers anyway.
>
> Yeah. An enum with '2' and '3' wouldn't work for Eric's desire to have
> enum values starting in letters, though. I was originally planning to
> replace it with an int, but then it's not introspectable.
Aw.
> An enum with 'v2' and 'v3' then?
Would work for me.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema, (continued)
Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema, Eric Blake, 2018/01/16
Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema, Max Reitz, 2018/01/29
[Qemu-devel] [RFC PATCH 03/10] qcow2: Let qcow2_create() handle protocol layer, Kevin Wolf, 2018/01/11
[Qemu-devel] [RFC PATCH 05/10] qcow2: Use BlockdevRef in qcow2_create2(), Kevin Wolf, 2018/01/11
[Qemu-devel] [RFC PATCH 04/10] qcow2: Pass BlockdevCreateOptions to qcow2_create2(), Kevin Wolf, 2018/01/11