[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10.5 04/20] tcg: Add generic vector expanders
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v10.5 04/20] tcg: Add generic vector expanders |
Date: |
Fri, 26 Jan 2018 12:17:42 +0000 |
User-agent: |
mu4e 1.0-alpha3; emacs 26.0.91 |
Richard Henderson <address@hidden> writes:
> Signed-off-by: Richard Henderson <address@hidden>
I'm slightly confused by the fact some previously added functions in
this series are seeing changes. Is this just of an artefact of building
up the TCG API in stages or should the changes be rolled into the
original patches?
Also there are still some ??? comments which should probably be
solidified before merging. Other than that:
<snip>
> diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
> index df2eabaa67..09fec5693f 100644
> --- a/tcg/tcg-op.h
> +++ b/tcg/tcg-op.h
> @@ -914,6 +914,7 @@ void tcg_gen_dup8i_vec(TCGv_vec, uint32_t);
> void tcg_gen_dup16i_vec(TCGv_vec, uint32_t);
> void tcg_gen_dup32i_vec(TCGv_vec, uint32_t);
> void tcg_gen_dup64i_vec(TCGv_vec, uint64_t);
> +void tcg_gen_dupi_vec(unsigned vece, TCGv_vec, uint64_t);
Odd that we add this one at a different time to the others.
> void tcg_gen_movi_v64(TCGv_vec, uint64_t);
> void tcg_gen_movi_v128(TCGv_vec, uint64_t, uint64_t);
> void tcg_gen_movi_v256(TCGv_vec, uint64_t, uint64_t, uint64_t, uint64_t);
> diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h
> index 4e62eda14b..b4e16cfbc3 100644
> --- a/tcg/tcg-opc.h
> +++ b/tcg/tcg-opc.h
> @@ -229,6 +229,12 @@ DEF(andc_vec, 1, 2, 0, IMPLVEC |
> IMPL(TCG_TARGET_HAS_andc_vec))
<snip>
> +
> +/* Expand the tuple (opc, type, vece) on the given arguments. */
> +void tcg_expand_vec_op(TCGOpcode, TCGType, unsigned, TCGArg, ...);
> +
> +/* Replicate a constant C accoring to the log2 of the element size.
> */
nit: according
<snip>
--
Alex Bennée
- [Qemu-devel] [PATCH v10.5 03/20] tcg: Standardize integral arguments to expanders, (continued)
- [Qemu-devel] [PATCH v10.5 03/20] tcg: Standardize integral arguments to expanders, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 02/20] tcg: Add types and basic operations for host vectors, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 06/20] tcg: Add generic vector ops for comparisons, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 07/20] tcg: Add generic vector ops for multiplication, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 05/20] tcg: Add generic vector ops for constant shifts, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 04/20] tcg: Add generic vector expanders, Richard Henderson, 2018/01/17
- Re: [Qemu-devel] [PATCH v10.5 04/20] tcg: Add generic vector expanders,
Alex Bennée <=
- [Qemu-devel] [PATCH v10.5 08/20] tcg: Add generic helpers for saturating arithmetic, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 09/20] tcg: Add generic vector helpers with a scalar operand, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 10/20] tcg/optimize: Handle vector opcodes during optimize, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 12/20] target/arm: Use vector infrastructure for aa64 add/sub/logic, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 11/20] target/arm: Align vector registers, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 14/20] target/arm: Use vector infrastructure for aa64 dup/movi, Richard Henderson, 2018/01/17