Re: [Qemu-devel] [qemu-s390x] [PATCH v4 07/10] s390-ccw: read stage2 boot loader data to find menu

[Thomas Huth]

On 25.01.2018 16:49, Collin L. Walling wrote:
> On 01/25/2018 10:25 AM, Thomas Huth wrote:
>> On 23.01.2018 19:26, Collin L. Walling wrote:
>>> Read the stage2 boot loader data block-by-block. We scan the
>>> current block for the string "zIPL" to detect the start of the
>>> boot menu banner. We then load the adjacent blocks (previous
>>> block and next block) to account for the possibility of menu
>>> data spanning multiple blocks.
>>>
>>> Signed-off-by: Collin L. Walling <address@hidden>
>>> ---
>>>   pc-bios/s390-ccw/bootmap.c | 94
>>> +++++++++++++++++++++++++++++++++++++++++++---
>>>   pc-bios/s390-ccw/bootmap.h |  1 +
>>>   pc-bios/s390-ccw/menu.c    |  5 +++
>>>   pc-bios/s390-ccw/menu.h    |  1 +
>>>   4 files changed, 96 insertions(+), 5 deletions(-)
>> Looks good to me now!
>>
>> Reviewed-by: Thomas Huth <address@hidden>
>>
> Thanks! The only change I plan on is moving the Stage1b struct declaration
> to this patch, as per your suggestion on another patch review.

Sure, feel free to keep my R-b in that case, too.

 Thomas