Re: [Qemu-devel] [PULL 0/3] Usb 20180125 patches

[Gerd Hoffmann]

On Thu, Jan 25, 2018 at 03:28:38PM +0000, Peter Maydell wrote:
> On 25 January 2018 at 09:16, Gerd Hoffmann <address@hidden> wrote:
> > Thomas Huth (1):
> >   usb: Remove legacy -usbdevice options (host, serial, disk and net)
> 
> Hi. This fails to build on FreeBSD:
> 
>   LINK    arm-softmmu/qemu-system-arm
> ../vl.o: In function `usb_device_add':
> /root/qemu/vl.c:1471: undefined reference to `usb_host_device_open'
> 
> There's still a call to that function in vl.c inside an
> ifndef CONFIG_LINUX...
> 
> If we can really remove the function we should get rid of the
> stub in hw/usb/host-stub.c and the prototype in usb.h too.

Indeed.  I'll fix it up.

The lines in vl.c dead code anyway since we switched to libusb and
dropped the linux/bsd specific usb-host code, so it all can simply be
deleted.

cheers,
  Gerd