[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu] vfio/common: Remove redundand copy of loca
From: |
Auger Eric |
Subject: |
Re: [Qemu-devel] [PATCH qemu] vfio/common: Remove redundand copy of local variable |
Date: |
Thu, 25 Jan 2018 14:53:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi,On 25/01/18 05:14, Alexey Kardashevskiy wrote:
> There is already @hostwin in vfio_listener_region_add() so there is no
> point in having the other one.
>
> Fixes: 2e4109de "vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2)"
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Eric
> ---
> hw/vfio/common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index b77be3a..3d652c8 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -435,7 +435,6 @@ static void vfio_listener_region_add(MemoryListener
> *listener,
> end = int128_get64(int128_sub(llend, int128_one()));
>
> if (container->iommu_type == VFIO_SPAPR_TCE_v2_IOMMU) {
> - VFIOHostDMAWindow *hostwin;
> hwaddr pgsize = 0;
>
> /* For now intersections are not allowed, we may relax this later */
>