[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/12] sdcard: replace fprintf() by qemu_hexd
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/12] sdcard: replace fprintf() by qemu_hexdump() |
Date: |
Tue, 23 Jan 2018 14:55:17 -0800 |
On Mon, Jan 22, 2018 at 7:21 PM, Philippe Mathieu-Daudé <address@hidden> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/sd/sd.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 3590099ce8..03263e08ae 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -44,13 +44,6 @@
>
> //#define DEBUG_SD 1
>
> -#ifdef DEBUG_SD
> -#define DPRINTF(fmt, ...) \
> -do { fprintf(stderr, "SD: " fmt , ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) do {} while(0)
> -#endif
> -
> #define ACMD41_ENQUIRY_MASK 0x00ffffff
> #define OCR_POWER_UP 0x80000000
> #define OCR_POWER_DELAY_NS 500000 /* 0.5ms */
> @@ -1630,13 +1623,7 @@ send_response:
> }
>
> #ifdef DEBUG_SD
> - if (rsplen) {
> - int i;
> - DPRINTF("Response:");
> - for (i = 0; i < rsplen; i++)
> - fprintf(stderr, " %02x", response[i]);
> - fputc('\n', stderr);
> - }
> + qemu_hexdump((const char *)response, stderr, "Response", rsplen);
> #endif
>
> return rsplen;
> --
> 2.15.1
>
>
- [Qemu-devel] [PATCH v3 00/12] SDCard: housekeeping, add tracing (part 4), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 01/12] sdcard: reorder SDState struct members, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 02/12] sdcard: replace DPRINTF() by trace events, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 03/12] sdcard: add a trace event for command responses, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 04/12] sdcard: replace fprintf() by qemu_hexdump(), Philippe Mathieu-Daudé, 2018/01/22
- Re: [Qemu-devel] [PATCH v3 04/12] sdcard: replace fprintf() by qemu_hexdump(),
Alistair Francis <=
- [Qemu-devel] [PATCH v3 05/12] sdcard: add more trace events, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 06/12] sdcard: do not trace CMD55 when expecting ACMD, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 07/12] sdcard: define SDMMC_CMD_MAX instead of using the magic '64', Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 08/12] sdcard: display command name when tracing CMD/ACMD, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 09/12] sdcard: display protocol used when tracing, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 10/12] sdcard: rename sd_set_$REG() functions called once as sd_reset_$REG(), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 11/12] sdcard: use G_BYTE from cutils, Philippe Mathieu-Daudé, 2018/01/22