[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] raw: Disable probing if image format is given by dr
From: |
Lin Ma |
Subject: |
[Qemu-devel] [PATCH] raw: Disable probing if image format is given by driver-specific options |
Date: |
Mon, 22 Jan 2018 15:21:02 +0800 |
If the user specifies image format through driver-specific options, The
format probing should be prohibited and the warning message should not
be printed.
e.g.:
$ qemu-system-x86_64 ... -drive file.file.filename=disk0.raw,file.driver=raw ...
WARNING: Image format was not specified for 'disk0.raw' and probing guessed raw.
Automatically detecting the format is dangerous for raw images, ...
Signed-off-by: Lin Ma <address@hidden>
---
blockdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 29d569a24e..ef4c167235 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -529,6 +529,8 @@ static BlockBackend *blockdev_init(const char *file, QDict
*bs_opts,
goto early_err;
}
qdict_put_str(bs_opts, "driver", buf);
+ } else if (qdict_haskey(bs_opts, "file.driver")) {
+ qdict_put_str(bs_opts, "driver", qdict_get_str(bs_opts,
"file.driver"));
}
on_write_error = BLOCKDEV_ON_ERROR_ENOSPC;
--
2.15.1
- [Qemu-devel] [PATCH] raw: Disable probing if image format is given by driver-specific options,
Lin Ma <=