[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify u
From: |
Zhang Chen |
Subject: |
[Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO |
Date: |
Fri, 19 Jan 2018 21:44:39 +0800 |
From: zhanghailiang <address@hidden>
If some errors happen during VM's COLO FT stage, it's important to
notify the users of this event. Together with 'x-colo-lost-heartbeat',
Users can intervene in COLO's failover work immediately.
If users don't want to get involved in COLO's failover verdict,
it is still necessary to notify users that we exited COLO mode.
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
migration/colo.c | 19 +++++++++++++++++++
qapi/migration.json | 35 +++++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index 8d2e3f8..790b122 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -516,6 +516,18 @@ out:
qemu_fclose(fb);
}
+ /*
+ * There are only two reasons we can go here, some error happened.
+ * Or the user triggered failover.
+ */
+ if (failover_get_state() == FAILOVER_STATUS_NONE) {
+ qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+ COLO_EXIT_REASON_ERROR, NULL);
+ } else {
+ qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+ COLO_EXIT_REASON_REQUEST, NULL);
+ }
+
/* Hope this not to be too long to wait here */
qemu_sem_wait(&s->colo_exit_sem);
qemu_sem_destroy(&s->colo_exit_sem);
@@ -746,6 +758,13 @@ out:
if (local_err) {
error_report_err(local_err);
}
+ if (failover_get_state() == FAILOVER_STATUS_NONE) {
+ qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+ COLO_EXIT_REASON_ERROR, NULL);
+ } else {
+ qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+ COLO_EXIT_REASON_REQUEST, NULL);
+ }
if (fb) {
qemu_fclose(fb);
diff --git a/qapi/migration.json b/qapi/migration.json
index 70e7b67..6fc95b7 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -869,6 +869,41 @@
'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
##
+# @COLO_EXIT:
+#
+# Emitted when VM finishes COLO mode due to some errors happening or
+# at the request of users.
+#
+# @mode: which COLO mode the VM was in when it exited.
+#
+# @reason: describes the reason for the COLO exit.
+#
+# Since: 2.12
+#
+# Example:
+#
+# <- { "timestamp": {"seconds": 2032141960, "microseconds": 417172},
+# "event": "COLO_EXIT", "data": {"mode": "primary", "reason": "request" }
}
+#
+##
+{ 'event': 'COLO_EXIT',
+ 'data': {'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
+
+##
+# @COLOExitReason:
+#
+# The reason for a COLO exit
+#
+# @request: COLO exit is due to an external request
+#
+# @error: COLO exit is due to an internal error
+#
+# Since: 2.12
+##
+{ 'enum': 'COLOExitReason',
+ 'data': [ 'request', 'error' ] }
+
+##
# @x-colo-lost-heartbeat:
#
# Tell qemu that heartbeat is lost, request it to do takeover procedures.
--
2.7.4
- [Qemu-devel] [PATCH V4 00/16] COLO: integrate colo frame with block replication and COLO proxy, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 01/16] filter-rewriter: fix memory leak for connection in connection_track_table, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 02/16] colo-compare: implement the process of checkpoint, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 03/16] colo-compare: use notifier to notify packets comparing result, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 04/16] COLO: integrate colo compare with colo frame, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 05/16] COLO: Add block replication into colo process, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 06/16] COLO: Remove colo_state migration struct, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 07/16] COLO: Load dirty pages into SVM's RAM cache firstly, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 08/16] ram/COLO: Record the dirty pages that SVM received, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 09/16] COLO: Flush memory data from ram cache, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO,
Zhang Chen <=
- [Qemu-devel] [PATCH V4 11/16] savevm: split the process of different stages for loadvm/savevm, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 12/16] COLO: flush host dirty ram from cache, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 13/16] filter: Add handle_event method for NetFilterClass, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 14/16] filter-rewriter: handle checkpoint and failover event, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 15/16] COLO: notify net filters about checkpoint/failover event, Zhang Chen, 2018/01/19
- [Qemu-devel] [PATCH V4 16/16] COLO: quick failover process by kick COLO thread, Zhang Chen, 2018/01/19
- Re: [Qemu-devel] [PATCH V4 00/16] COLO: integrate colo frame with block replication and COLO proxy, Zhang Chen, 2018/01/30