[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v4 09/23] replay: make safe vmstop at record/rep
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v4 09/23] replay: make safe vmstop at record/replay |
Date: |
Fri, 19 Jan 2018 11:43:44 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Pavel Dovgalyuk <address@hidden>
This patch disables bdrv flush/drain in record/replay mode.
When block request is in the replay queue it cannot be processed
with drain/flush until it is found in the log.
Therefore vm should just stop leaving unfinished operations
in the queue.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
cpus.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/cpus.c b/cpus.c
index 2cb0af9..7b6ce74 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1004,9 +1004,10 @@ static int do_vm_stop(RunState state)
qapi_event_send_stop(&error_abort);
}
- bdrv_drain_all();
- replay_disable_events();
- ret = bdrv_flush_all();
+ if (!replay_events_enabled()) {
+ bdrv_drain_all();
+ ret = bdrv_flush_all();
+ }
return ret;
}
- [Qemu-devel] [RFC PATCH v4 00/23] replay additions, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 01/23] This patch adds a condition before overwriting exception_index fields., Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 02/23] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 03/23] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 04/23] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 05/23] replay: fix processing async events, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 06/23] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 07/23] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 08/23] replay: added replay log format description, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 09/23] replay: make safe vmstop at record/replay,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v4 10/23] replay: save prior value of the host clock, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 11/23] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 14/23] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2018/01/19
- [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2018/01/19