[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn |
Date: |
Thu, 18 Jan 2018 14:19:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/18/2018 06:43 AM, Paolo Bonzini wrote:
> It is called from qcow2_invalidate_cache in coroutine context (incoming
Why is a qcow2 function calling qed code? Definitely a copy-paste bug,
but I'm not sure of the right fix.
> migration runs in a coroutine), so it's cleaner if metadata is always
> loaded from a coroutine.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/qed.c | 40 +++++++++++++++++++++++++++++++++++++---
> 1 file changed, 37 insertions(+), 3 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 2/7] qcow2: make qcow2_co_create2() a coroutine_fn, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 3/7] qcow2: make qcow2_do_open a coroutine_fn, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2018/01/18
- Re: [Qemu-devel] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn,
Eric Blake <=
- [Qemu-devel] [PATCH 1/7] block: rename .bdrv_create() to .bdrv_co_create_opts(), Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 6/7] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 7/7] block: convert bdrv_check callback to coroutine_fn, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 5/7] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2018/01/18
- Re: [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context, Eric Blake, 2018/01/18