[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4) |
Date: |
Thu, 18 Jan 2018 14:34:21 +0100 |
On Thu, 18 Jan 2018 13:10:13 +0000
Peter Maydell <address@hidden> wrote:
> On 18 January 2018 at 13:06, Igor Mammedov <address@hidden> wrote:
> > I've looked and such case is rather an exception,
> > I can fix it up in 2 ways:
> > 1st:
> > target/arm/cpu.h
> > +#if !defined(CONFIG_USER_ONLY)
> > +#define TARGET_DEFAULT_CPU_TYPE TYPE_ARM_CPU
> > +else
> > +#define TARGET_DEFAULT_CPU_TYPE ARM_CPU_TYPE_NAME("any")
> > +#endif
>
> This is weird, because TYPE_ARM_CPU isn't really
> a sensible thing to use for anything, so you've really set
> it up as a "this is only of any use for null-machine.c",
> in which case you should just do that in null-machine.c.
yep, that would be only for null-machine.c use as proxy type,
however null-machine.c is build for every target so this
proxy type can't be defined null-machine.c unless we resort
to ifdef ladder there.
How about adding to each $ARCH/cpu.h a null-machine dedicated
define:
#define CPU_RESOLVING_TYPE TYPE_FOO_CPU
using that in null machine and renaming
TARGET_DEFAULT_CPU_TYPE to USERONLY_DEFAULT_CPU_TYPE
but I'd still keep it within $ARCH/cpu.h so we won't
have to create a bunch of new linux-user/$ARCH/target_elf.h
files just for that and duplicate it to bsd-user/$ARCH/target_elf.h
> thanks
> -- PMM
- [Qemu-devel] [PATCH 22/24] cpu: get rid of unused cpu_init() defines, (continued)
- [Qemu-devel] [PATCH 22/24] cpu: get rid of unused cpu_init() defines, Igor Mammedov, 2018/01/17
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/17
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/17
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/17
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4),
Igor Mammedov <=
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Philippe Mathieu-Daudé, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18