[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: add block_set_io_throttle virtio-blk-pci
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] block: add block_set_io_throttle virtio-blk-pci QMP example |
Date: |
Thu, 18 Jan 2018 10:38:18 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Jan 17, 2018 at 09:07:00AM +0000, Stefan Hajnoczi wrote:
> The block_set_io_throttle command can look up BlockBackends by the
> attached qdev device ID. virtio-blk-pci is a special case because the
> actual VirtIOBlock device is the "/virtio-backend" child of the PCI
> adapter device.
>
> Add a QMP schema example so clients will know how to use
> block_set_io_throttle on the virtio-blk-pci device.
>
> The alternative is to implement some sort of aliasing for qmp_get_blk()
> but that is likely to cause confusion and could break future use cases.
> Let's not go there.
>
> Cc: Kevin Wolf <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qapi/block-core.json | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature