[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] nbd/server: Better error for NBD_OPT_EXPORT_NAME
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 3/6] nbd/server: Better error for NBD_OPT_EXPORT_NAME failure |
Date: |
Wed, 17 Jan 2018 20:26:22 -0600 |
When a client abruptly disconnects before we've finished reading
the name sent with NBD_OPT_EXPORT_NAME, we are better off logging
the failure as EIO (we can't communicate with the client), rather
than EINVAL (the client sent bogus data).
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
---
nbd/server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd/server.c b/nbd/server.c
index b9efdcc605d..31c1d324297 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -299,7 +299,7 @@ static int nbd_negotiate_handle_export_name(NBDClient
*client,
}
if (nbd_read(client->ioc, name, client->optlen, errp) < 0) {
error_prepend(errp, "read failed: ");
- return -EINVAL;
+ return -EIO;
}
name[client->optlen] = '\0';
client->optlen = 0;
--
2.14.3
- [Qemu-devel] [PULL 0/6] NBD patches through 17 Jan, Eric Blake, 2018/01/17
- [Qemu-devel] [PULL 3/6] nbd/server: Better error for NBD_OPT_EXPORT_NAME failure,
Eric Blake <=
- [Qemu-devel] [PULL 1/6] nbd/server: Hoist nbd_reject_length() earlier, Eric Blake, 2018/01/17
- [Qemu-devel] [PULL 4/6] nbd/server: Add va_list form of nbd_negotiate_send_rep_err(), Eric Blake, 2018/01/17
- [Qemu-devel] [PULL 2/6] nbd/server: refactor negotiation functions parameters, Eric Blake, 2018/01/17
- [Qemu-devel] [PULL 6/6] nbd/server: structurize option reply sending, Eric Blake, 2018/01/17
- [Qemu-devel] [PULL 5/6] nbd/server: Add helper functions for parsing option payload, Eric Blake, 2018/01/17
- Re: [Qemu-devel] [PULL 0/6] NBD patches through 17 Jan, Peter Maydell, 2018/01/18