[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] iotests: Make 200 run on tmpfs
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2] iotests: Make 200 run on tmpfs |
Date: |
Wed, 17 Jan 2018 09:05:59 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Jan 17, 2018 at 02:50:15PM +0100, Max Reitz wrote:
> 200 currently fails on tmpfs because it sets cache=none. However,
> without that (and aio=native), the test still works now and it fails
> before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So
> we can probably remove the aio=native safely, and replace cache=none by
> cache=$CACHEMODE.
>
> Signed-off-by: Max Reitz <address@hidden>
Tested-by, and:
Reviewed-by: Jeff Cody <address@hidden>
> ---
> v2: Use cache=$CACHEMODE instead of dropping it altogether [Stefan]
> ---
> tests/qemu-iotests/200 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/200 b/tests/qemu-iotests/200
> index d8787ddb46..ddbdedc476 100755
> --- a/tests/qemu-iotests/200
> +++ b/tests/qemu-iotests/200
> @@ -60,7 +60,7 @@ qemu_comm_method="qmp"
> _launch_qemu -device pci-bridge,id=bridge1,chassis_nr=1,bus=pci.0 \
> -object iothread,id=iothread0 \
> -device
> virtio-scsi-pci,bus=bridge1,addr=0x1f,id=scsi0,iothread=iothread0 \
> - -drive
> file="${TEST_IMG}",media=disk,if=none,cache=none,id=drive_sysdisk,aio=native,format=$IMGFMT
> \
> + -drive
> file="${TEST_IMG}",media=disk,if=none,cache=$CACHEMODE,id=drive_sysdisk,format=$IMGFMT
> \
> -device
> scsi-hd,drive=drive_sysdisk,bus=scsi0.0,id=sysdisk,bootindex=0
> h1=$QEMU_HANDLE
>
> --
> 2.14.3
>