[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 05/13] qapi: remove '-q' arg to diff when com
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 05/13] qapi: remove '-q' arg to diff when comparing QAPI output |
Date: |
Mon, 15 Jan 2018 11:08:44 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/15/2018 11:02 AM, Daniel P. Berrange wrote:
> When the qapi schema tests fail they merely print that the expected
> output didn't match the actual output. This is largely useless when
> trying diagnose what went wrong. Removing the '-q' arg to diff
> means that it is still silent on successful tests, but when it
> fails we'll see details of the incorrect output.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> tests/Makefile.include | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 00/13] Support building with py2 or py3, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 01/13] qapi: use items()/values() intead of iteritems()/itervalues(), Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 02/13] qapi: Use OrderedDict from standard library if available, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 03/13] qapi: adapt to moved location of StringIO module in py3, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 04/13] qapi: Adapt to moved location of 'maketrans' function in py3, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 05/13] qapi: remove '-q' arg to diff when comparing QAPI output, Daniel P. Berrange, 2018/01/15
- Re: [Qemu-devel] [PATCH v4 05/13] qapi: remove '-q' arg to diff when comparing QAPI output,
Eric Blake <=
- [Qemu-devel] [PATCH v4 06/13] qapi: ensure stable sort ordering when checking QAPI entities, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 07/13] qapi: force a UTF-8 locale for running Python, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 08/13] scripts: ensure signrom treats data as bytes, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 09/13] configure: allow use of python 3, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 10/13] input: add missing JIS keys to virtio input, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v4 11/13] ui: update keycodemapdb to get py3 fixes, Daniel P. Berrange, 2018/01/15