qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)
Date: Mon, 15 Jan 2018 11:04:32 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 01/15/2018 10:51 AM, Peter Maydell wrote:
> On 13 January 2018 at 05:07, Philippe Mathieu-Daudé <address@hidden> wrote:
>> Since v6:
>> - addressed Peter reviews
>>   - do not use an unique Property[] for both sysbus/pci
>>     Peter didn't recommend me to use the qdev_property_add_static() API since
>>     it is only used by the ARM cpus and may be due for removal, however I 
>> found
>>     it cleaner.
> 
> Your cover letter says this but patches 3 and 14 in the v7 you sent
> to the list use qdev_property_add_static(). Did you send the wrong
> version of the code?

The cover is not clear, I'll try to reword it:

'''
Peter recommended me to NON use the qdev_property_add_static() API since
it is only used by the ARM cpus and may be due for removal.

However I found using qdev_property_add_static() cleaner, and sent this
series with using the not recommended qdev_property_add_static().
'''

Is it possible to share properties without using qdev_property_add_static()?

Thanks,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]