Re: [Qemu-devel] [PATCH v10 01/14] migration: Make migrate_fd_error() the owner of the Error

[Dr. David Alan Gilbert]

* Juan Quintela (address@hidden) wrote:
> So far, we had to free the error after each caller, so just do it
> here.  Once there, tls.c was leaking the error.
> 
> Signed-off-by: Juan Quintela <address@hidden>

This clashes a bit with my
'Route errors down through migration_channel_connect'
'Allow migrate_fd_connect to take an Error *'

pair; I think they also clean up the leak and actually end up displaying
the error.

Dave

> ---
>  migration/channel.c   |  1 -
>  migration/migration.c | 10 ++++------
>  migration/migration.h |  4 ++--
>  migration/socket.c    |  1 -
>  4 files changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/migration/channel.c b/migration/channel.c
> index 70ec7ea3b7..1dd2ae1530 100644
> --- a/migration/channel.c
> +++ b/migration/channel.c
> @@ -71,7 +71,6 @@ void migration_channel_connect(MigrationState *s,
>          migration_tls_channel_connect(s, ioc, hostname, &local_err);
>          if (local_err) {
>              migrate_fd_error(s, local_err);
> -            error_free(local_err);
>          }
>      } else {
>          QEMUFile *f = qemu_fopen_channel_output(ioc);
> diff --git a/migration/migration.c b/migration/migration.c
> index a5be4592a6..085e88c625 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1159,16 +1159,14 @@ static void migrate_fd_cleanup(void *opaque)
>      block_cleanup_parameters(s);
>  }
>  
> -void migrate_set_error(MigrationState *s, const Error *error)
> +void migrate_set_error(MigrationState *s, Error *error)
>  {
>      qemu_mutex_lock(&s->error_mutex);
> -    if (!s->error) {
> -        s->error = error_copy(error);
> -    }
> +    error_propagate(&s->error, error);
>      qemu_mutex_unlock(&s->error_mutex);
>  }
>  
> -void migrate_fd_error(MigrationState *s, const Error *error)
> +void migrate_fd_error(MigrationState *s, Error *error)
>  {
>      trace_migrate_fd_error(error_get_pretty(error));
>      assert(s->to_dst_file == NULL);
> @@ -1448,7 +1446,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool 
> blk,
>      }
>  
>      if (local_err) {
> -        migrate_fd_error(s, local_err);
> +        migrate_fd_error(s, error_copy(local_err));
>          error_propagate(errp, local_err);
>          return;
>      }
> diff --git a/migration/migration.h b/migration/migration.h
> index 2c8c53847a..29a7b79a39 100644
> --- a/migration/migration.h
> +++ b/migration/migration.h
> @@ -177,8 +177,8 @@ bool  migration_has_all_channels(void);
>  
>  uint64_t migrate_max_downtime(void);
>  
> -void migrate_set_error(MigrationState *s, const Error *error);
> -void migrate_fd_error(MigrationState *s, const Error *error);
> +void migrate_set_error(MigrationState *s, Error *error);
> +void migrate_fd_error(MigrationState *s, Error *error);
>  
>  void migrate_fd_connect(MigrationState *s);
>  
> diff --git a/migration/socket.c b/migration/socket.c
> index 248a798543..6d49903978 100644
> --- a/migration/socket.c
> +++ b/migration/socket.c
> @@ -81,7 +81,6 @@ static void socket_outgoing_migration(QIOTask *task,
>      if (qio_task_propagate_error(task, &err)) {
>          trace_migration_socket_outgoing_error(error_get_pretty(err));
>          migrate_fd_error(data->s, err);
> -        error_free(err);
>      } else {
>          trace_migration_socket_outgoing_connected(data->hostname);
>          migration_channel_connect(data->s, sioc, data->hostname);
> -- 
> 2.14.3
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK