Re: [Qemu-devel] [PATCH v6 03/13] sdhci: refactor same sysbus/pci properties into a common one

[Philippe Mathieu-Daudé]

On Fri, Jan 12, 2018 at 2:05 PM, Peter Maydell <address@hidden> wrote:
> On 11 January 2018 at 19:30, Philippe Mathieu-Daudé <address@hidden> wrote:
>> Now both sysbus/pci classes inherit of the 'pending-insert-quirk' property,
>> which is a HCI dependent property (regardless if accessed through a MMIO
>> sysbus or a PCI bus).
>> So far only the BCM implementation has to use it.
>>
>> Add sysbus/pci/sdbus comments to have clearer code blocks separation.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> Reviewed-by: Alistair Francis <address@hidden>
>
> I'm not sure about this patch, because it means that we now have
> no mechanism for having a property which exists on the sysbus
> device but not on the PCI device (and as per my comments on the
> last patch in this set, we do need to be able to do that).

This might be what Alistair tried to explain me in his previous reviews...

I'll respin, thanks!

Phil.