qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27
Date: Fri, 12 Jan 2018 08:28:54 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

Hi Paolo,

On 01/12/2018 08:11 AM, Paolo Bonzini wrote:
> Using "fedora:latest" makes behavior different depending on when you
> actually pulled the image from the docker repository.  In my case,
> the supposedly "latest" image was a Fedora 25 download from 8 months
> ago, and the new "test-debug" test was failing.
> 
> Use "27" to improve reproducibility and make it clear when the image
> is obsolete.
> 
> Cc: Fam Zheng <address@hidden>
> Cc: Marc-André Lureau <address@hidden>

I wonder what script you are using, and if the R: tag in MAINTAINERS is
that useful, since I saw few docker patches I'm interestd in but I was
not CC'd:

$ ./scripts/get_maintainer.pl -f tests/docker/dockerfiles/fedora.docker
"Alex Bennée" <address@hidden> (maintainer:Build and test au...)
Fam Zheng <address@hidden> (maintainer:Build and test au...)
"Philippe Mathieu-Daudé" <address@hidden> (reviewer:Build and test au...)

> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker 
> b/tests/docker/dockerfiles/fedora.docker
> index 32de731..714adad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:latest
> +FROM fedora:27

I'd rather use the deprecation approach like we use for Debian,
see tests/docker/dockerfiles/debian.docker.

That said, you remind me of a series doing the same for Ubuntu I forgot
to send, if you want I can add fedora25 and fedora27 before sending.

Regards,

Phil.

>  ENV PACKAGES \
>      ccache gettext git tar PyYAML sparse flex bison python2 bzip2 hostname \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> 

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]