[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver
Date: Thu, 11 Jan 2018 14:48:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 10/01/2018 19:33, Stefan Hajnoczi wrote:
>> +
>> +    /* Fields protected by @lock */
> Does this lock serve any purpose?  I didn't see a place where these
> fields is accessed from multiple threads.  Perhaps you're trying to
> prepare for multiqueue, but then other things like the
> BDRVNVMeState->inflight counter aren't protected so it doesn't make
> sense.

Other drivers are already thread safe (e.g. block/vdi.c since commit
1e88663979, "vdi: make it thread-safe", 2017-07-17).  So I'd be in favor
of (fixing and) keeping the lock.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]