[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] possible_cpus: add CPUArchId::type field
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3] possible_cpus: add CPUArchId::type field |
Date: |
Wed, 10 Jan 2018 14:45:17 -0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Jan 10, 2018 at 04:22:50PM +0100, Igor Mammedov wrote:
> Remove dependency of possible_cpus on 1st CPU instance,
> which decouples configuration data from CPU instances that
> are created using that data.
>
> Also later it would be used for enabling early cpu to numa node
> configuration at runtime qmp_query_hotpluggable_cpus() should
> provide a list of available cpu slots at early stage,
> before machine_init() is called and the 1st cpu is created,
> so that mgmt might be able to call it and use output to set
> numa mapping.
>
> Use MachineClass::possible_cpu_arch_ids() callback to set
> cpu type info, along with the rest of possible cpu properties,
> to let machine define which cpu type* will be used.
>
> * for SPAPR it will be a spapr core type and for ARM/s390x/x86
> a respective descendant of CPUClass.
>
> Move parse_numa_opts() in vl.c after cpu_model is parsed into
> cpu_type so that possible_cpu_arch_ids() would know which
> cpu_type to use during layout initialization.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: David Gibson <address@hidden>
Queued to machine-next, thanks.
--
Eduardo