[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing

From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments
Date: Wed, 10 Jan 2018 11:43:06 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Laurent Vivier <address@hidden> wrote:
> On 10/01/2018 10:21, Laurent Vivier wrote:
>> On 10/01/2018 09:47, Juan Quintela wrote:
>>> Peter Xu <address@hidden> wrote:
>>>> On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote:
>>>>> Argument file is also needed there.
>>>>> Signed-off-by: Juan Quintela <address@hidden>
>>>> Reviewed-by: Peter Xu <address@hidden>
>>>> Does it also mean this?
>>>> Fixes: aaf89c8a49a8c ("test: port postcopy test to ppc64")
>>> Dunno.  I was trying to consolidate the command line options for ppc and
>>> x86 when I found this problem.  I haven't tested of ppc.
>> I don't think it is needed. I think the content of the nvram is migrated
>> (otherwise the test wouldn't work at all).
>> The nvram is created by default, we need the command line parameter only
>> to populate it from a file.
> A better change would be to use "-prom-env" instead of "-driver
> if=pflash". I can send the patch if you want to add it in your series.

Told the command line and I will add to the line.

And using the same command in both sides makes easier to see that it is

Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]