[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/14] Migration pull request
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 00/14] Migration pull request |
Date: |
Tue, 9 Jan 2018 18:24:00 +0000 |
On 5 January 2018 at 09:59, Juan Quintela <address@hidden> wrote:
> Eric Blake <address@hidden> wrote:
>> On 01/03/2018 03:38 AM, Juan Quintela wrote:
>>> Hi
>>>
>>> This are the changes for migration that are already reviewed.
>>>
>>> Please, apply.
>>>
>>
>>> Alexey Perevalov (6):
>>> migration: introduce postcopy-blocktime capability
>>> migration: add postcopy blocktime ctx into MigrationIncomingState
>>> migration: calculate vCPU blocktime on dst side
>>> migration: postcopy_blocktime documentation
>>> migration: add blocktime calculation into migration-test
>>> migration: add postcopy total blocktime into query-migrate
>>
>> I had unanswered questions about these patches in the v12 series, where
>> I'm not sure if the interface is still quite right.
>
> To be fair, I had alroady integrated the patches before I saw your questions.
>
>> We're still early
>> enough that we could adjust the interface after the fact depending on
>> how the questions are answered;
>
> I think this is the best approach, so far I can see two questions:
>
> - do we want to make it conditional? it requires some locking, but I
> haven't meassured it to see how slow/fast is it.
>
> - the other was documentation.
>
> I will like Alexey to answer. Depending of how slow it is, I can agree
> to make it non-optional.
So have you come to a consensus on whether you'd like me to apply
this pull request or not ?
thanks
-- PMM
- [Qemu-devel] [PULL 08/14] migration: add postcopy blocktime ctx into MigrationIncomingState, (continued)
- [Qemu-devel] [PULL 08/14] migration: add postcopy blocktime ctx into MigrationIncomingState, Juan Quintela, 2018/01/03
- [Qemu-devel] [PULL 09/14] migration: calculate vCPU blocktime on dst side, Juan Quintela, 2018/01/03
- [Qemu-devel] [PULL 11/14] migration: add blocktime calculation into migration-test, Juan Quintela, 2018/01/03
- [Qemu-devel] [PULL 10/14] migration: postcopy_blocktime documentation, Juan Quintela, 2018/01/03
- [Qemu-devel] [PULL 12/14] migration: add postcopy total blocktime into query-migrate, Juan Quintela, 2018/01/03
- [Qemu-devel] [PULL 13/14] migration: Guard ram_bytes_remaining against early call, Juan Quintela, 2018/01/03
- [Qemu-devel] [PULL 14/14] migration: finalize current_migration object, Juan Quintela, 2018/01/03
- Re: [Qemu-devel] [PULL 00/14] Migration pull request, Eric Blake, 2018/01/04
- Re: [Qemu-devel] [PULL 00/14] Migration pull request, Peter Maydell, 2018/01/11