[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option
Date: Tue, 9 Jan 2018 14:45:16 +0100
User-agent: NeoMutt/20171215


> > We can and should say no.  Sometimes we can also say yes though. :)
> > 
> > I just think that Braille is worth a special case because a subset of
> > our user base (blind people) will use it 100% of the time, plus it is
> > not supported by libvirt and hence virt-manager.
> OK, then let's go forward and use your "-braille serial|usb" patch, and
> nuke the -usbdevice option completely (assuming Gerd agrees, being the
> USB maintainer).

Hmm.  I'm not sure it is a good idea to rush new convinience shortcuts.

In the discussion I've seen a bunch of different possible approaches ...

  (1) new -braille option, hardcoded.
  (2) new -braille option, with some "replace shortcuts with long
      versions" mechanism we could use for other shortcuts too.
  (3) magically create chardev in usb-braille realize.
  (4) allow chardev properties have a default.
  (5) stick with -usbdevice.

... with no clear winnner.

I think nobody wants (5), but I think it is the best short-term option
while we are busy hashing out which of options 1 ... 4 (or possibly
something else) works best long-term.

Also it's not clear what is supposed to happen for "-braille serial".
Will that effectively transform from one shortcut to another (-serial

So I'd suggest to simply drop the usb_legacy_register() calls +
registered functions from most (all but braille?) devices.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]