qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator


From: Peter Maydell
Subject: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator
Date: Mon, 8 Jan 2018 17:10:42 +0000

In commit c97d6d2cdf97ed we accidentally added code to configure
that uses '==' for string equality testing. This is a bashism --
the portable way to write this is '='.

This fixes the "Unexpected operator error" complaint produced
if the system /bin/sh is dash.

Fixes: c97d6d2cdf97ed
Reported-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
As an aside, it's annoying that this doesn't make configure fail;
otherwise it wouldn't have got through my build tests.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 56f9716..6a04082 100755
--- a/configure
+++ b/configure
@@ -5076,7 +5076,7 @@ fi
 
 #################################################
 # Check to see if we have the Hypervisor framework
-if [ "$darwin" == "yes" ] ; then
+if [ "$darwin" = "yes" ] ; then
   cat > $TMPC << EOF
 #include <Hypervisor/hv.h>
 int main() { return 0;}
-- 
2.7.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]