Re: [Qemu-devel] [PULL 00/18] Net patches

[Ed Swierk]

On Mon, Jan 8, 2018 at 7:10 AM, Eric Blake <address@hidden> wrote:
>
> On 01/08/2018 07:30 AM, Ed Swierk via Qemu-devel wrote:
>
> > Applied, thanks.
> >
> > PS: just noticed, but "Ed Swierk via Qemu-devel <address@hidden>"
> > is a bit of an odd Author string to end up in git commit logs, so you
> > and/or Ed might like to fix that up for any future patches.
> >
> >
> > Thanks for pointing that out. I wonder if it's happening because I let
> > git-send-email automatically fill in the From: line.
>
> It's also a factor of how strict your ISP is about DMARC handling; the
> list automatically rewrites the 'From:' header to insert the 'via
> Qemu-devel' tag if it detects DMARC settings at your ISP that won't
> allow your email through as originally written.  Sadly, mailman doesn't
> know to insert a manual 'From:' line in the body when it rewrites the
> original From: header; but if you know that DMARC settings are going to
> munge your original header, you can probably convince git to always
> insert an explicit From: line in the message body to override whatever
> munging the list does.

I'm trying to figure out what I need to fix on my end. I went back and
looked at the email headers. Here are the two that ended up with the
wrong author:

Return-Path: <address@hidden>
Received: from eswierk-sc.localdomain
(67-207-112-138.static.wiline.com. [67.207.112.138])
        by smtp.gmail.com with ESMTPSA id
d9sm20150979pfk.117.2017.11.14.15.23.43
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Tue, 14 Nov 2017 15:23:44 -0800 (PST)
From: Ed Swierk <address@hidden>
To: Jason Wang <address@hidden>,
        "Daniel P . Berrange" <address@hidden>,
        Stefan Hajnoczi <address@hidden>
Cc: address@hidden,
        Ed Swierk <address@hidden>
Subject: [PATCH 1/2] e1000, e1000e: Move per-packet TX offload flags
out of context state
Date: Tue, 14 Nov 2017 15:23:33 -0800
Message-Id: <address@hidden>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <address@hidden>
References: <address@hidden>

Return-Path: <address@hidden>
Received: from eswierk-sc.localdomain
(67-207-112-138.static.wiline.com. [67.207.112.138])
        by smtp.gmail.com with ESMTPSA id
d9sm20150979pfk.117.2017.11.14.15.23.45
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Tue, 14 Nov 2017 15:23:45 -0800 (PST)
From: Ed Swierk <address@hidden>
To: Jason Wang <address@hidden>,
        "Daniel P . Berrange" <address@hidden>,
        Stefan Hajnoczi <address@hidden>
Cc: address@hidden,
        Ed Swierk <address@hidden>
Subject: [PATCH 2/2] e1000: Separate TSO and non-TSO contexts, fixing
UDP TX corruption
Date: Tue, 14 Nov 2017 15:23:34 -0800
Message-Id: <address@hidden>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <address@hidden>
References: <address@hidden>


This one had the correct author:

Return-Path: <address@hidden>
Received: from eswierk-sc.localdomain
(67-207-112-138.static.wiline.com. [67.207.112.138])
        by smtp.gmail.com with ESMTPSA id s3sm4082810pfk.7.2017.11.16.06.06.36
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Thu, 16 Nov 2017 06:06:37 -0800 (PST)
From: Ed Swierk <address@hidden>
To: Jason Wang <address@hidden>,
        "Daniel P . Berrange" <address@hidden>,
        Stefan Hajnoczi <address@hidden>,
        Dmitry Fleytman <address@hidden>
Cc: address@hidden,
        Ed Swierk <address@hidden>
Subject: [PATCH v3 REPOST] net: Transmit zero UDP checksum as 0xFFFF
Date: Thu, 16 Nov 2017 06:06:06 -0800
Message-Id: <address@hidden>
X-Mailer: git-send-email 1.9.1


Is there any way to tell exactly what mailman didn't like about the
first two, causing it to change the author?

--Ed