[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure |
Date: |
Mon, 08 Jan 2018 10:29:25 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 01/05/2018 12:47 AM, Michael Clark wrote:
>
>>>
>>>> +##
>>>> +{ 'struct': 'CpuInfoRISCV', 'data': { 'pc': 'int' } }
>>>
>>> Should this be 'uint64' or other specific type, rather than the generic
>>> 'int' (which happens to be 64 bits, but signed)? Other architectures
>>> use 'int' because of history, but we could use this chance to improve
>>> things if desired.
>>>
>>
>> I'll have to defer to your better judgement as to whether we need to change
>> this. I like consistency. Is it a change that needs to be made to multiple
>> arches? It sounds relatively low risk. You decide.
>>
>> QAPI Schema
>> M: Eric Blake <address@hidden>
>> M: Markus Armbruster <address@hidden>
>
> I'm fine if this patch uses 'int' for consistency, and will wait for
Me too.
> Markus to chime in on whether changing CpuInfo to use specific integer
> types in general is worth a separate series later on.
I guess it is.
Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, no-reply, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Michael Clark, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Michael Clark, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Fam Zheng, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Michael Clark, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Fam Zheng, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Alex Bennée, 2018/01/05
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Fam Zheng, 2018/01/05